-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed Legrand/Bticino LedInDark feature #6032
Conversation
src/converters/fromZigbee.js
Outdated
@@ -3930,6 +3930,13 @@ const converters = { | |||
} | |||
}, | |||
}, | |||
legrand_ledInDark: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rename to legrand_led_in_dark
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, done! (Sorry, first contribution)
src/devices/legrand.js
Outdated
// Some require coverInverted: | ||
// - https://github.com/Koenkk/zigbee2mqtt/issues/15101#issuecomment-1356787490 | ||
// - https://github.com/Koenkk/zigbee2mqtt/issues/16090 | ||
fingerprint: [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was this removed? It will break 067776
for some users.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's correct, and it was not my intention to break anything.
Until recently, this was required as there was no other alternative. Now that OTA is available, those devices work perfectly with the classic (non inverted) 067776
.
I am preparing another PR with more extensive changes to the 067776
, (add support for Venetian / BSO mode) and wanted to avoid duplication.
The change has been reverted for now nevertheless, hope that is OK.
c2b68df
to
8dc26df
Compare
thanks! |
This PR: